Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Display funding in trade history table and update layout #2540

Merged
merged 10 commits into from
Jul 21, 2023

Conversation

avclarke
Copy link
Contributor

@avclarke avclarke commented Jun 29, 2023

Description

  1. Add a column for accrued funding in the trade history table
  2. Update the table layout (desktop/tablet)

Related issue

Closes Kwenta/kwenta-private#55 and Kwenta/kwenta-private#54

Motivation and Context

Popular request from traders

Screenshots (if appropriate):

Desktop / Dark

截屏2023-07-21 13 28 59

Desktop / Light

截屏2023-07-21 13 29 50

Tablet / Dark

截屏2023-07-21 13 38 05

Tablet / Light

截屏2023-07-21 13 38 22

@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jul 21, 2023 6:08pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jul 21, 2023 6:08pm

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2540 (a250056) into dev (7825b4c) will decrease coverage by 0.11%.
The diff coverage is 28.30%.

@@            Coverage Diff             @@
##              dev    Kwenta/kwenta#2540      +/-   ##
==========================================
- Coverage   51.31%   51.21%   -0.11%     
==========================================
  Files         381      381              
  Lines       11486    11513      +27     
  Branches     2723     2742      +19     
==========================================
+ Hits         5894     5896       +2     
- Misses       5368     5393      +25     
  Partials      224      224              
Impacted Files Coverage Δ
...c/sections/futures/MarketDetails/MarketDetails.tsx 88.50% <ø> (ø)
...ections/futures/MobileTrade/UserTabs/TradesTab.tsx 44.44% <ø> (+1.58%) ⬆️
...ions/futures/TradingHistory/TradesHistoryTable.tsx 45.12% <ø> (ø)
packages/app/src/state/futures/selectors.ts 47.47% <ø> (-0.07%) ⬇️
...ackages/app/src/sections/futures/Trades/Trades.tsx 28.08% <15.00%> (-12.82%) ⬇️
...es/app/src/sections/futures/Trades/TimeDisplay.tsx 38.88% <50.00%> (+3.59%) ⬆️
...c/sections/futures/UserInfo/TableMarketDetails.tsx 68.75% <66.66%> (-2.68%) ⬇️
packages/app/src/sections/futures/PositionType.tsx 73.68% <71.42%> (-3.24%) ⬇️
packages/app/src/utils/futures.ts 59.02% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LeifuChen LeifuChen changed the title Feat: Display funding in trade history table (WIP for smaller screens) Feat: Display funding in trade history table and update tablet layout Jul 21, 2023
@LeifuChen LeifuChen marked this pull request as ready for review July 21, 2023 10:21
@LeifuChen LeifuChen changed the title Feat: Display funding in trade history table and update tablet layout Feat: Display funding in trade history table and update layout Jul 21, 2023
@LeifuChen LeifuChen merged commit 428c5df into dev Jul 21, 2023
5 of 6 checks passed
@LeifuChen LeifuChen deleted the feat/accrued-funding branch July 21, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants