Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Price in Edit Position Modal and Mobile User Tabs #2471

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Fix: Price in Edit Position Modal and Mobile User Tabs #2471

merged 3 commits into from
Jun 13, 2023

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Jun 12, 2023 •
edited
Loading

Description

  1. Use suggestedDecimals for fill price and liquidation price (#2469)
  2. Add count badges to user info tabs on mobile (#2458)
  3. Add funding to mobile positions (#2459)

Related issue

closes Kwenta/kwenta-private#74
closes Kwenta/kwenta-private#373
closes Kwenta/kwenta-private#80

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

image
image
image

@vercel
Copy link

vercel bot commented Jun 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
kwenta ✅ Ready (Inspect) Visit Preview Jun 12, 2023 9:24pm
kwenta-storybook ✅ Ready (Inspect) Visit Preview Jun 12, 2023 9:24pm

@LeifuChen LeifuChen changed the title Fix: Price in Edit Position Modal Fix: Price in Edit Position Modal and Mobile User Tabs Jun 12, 2023
@LeifuChen LeifuChen marked this pull request as ready for review June 12, 2023 21:21
avclarke
avclarke reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@avclarke avclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, LGTM.

@platschi platschi merged commit c3dcd62 into dev Jun 13, 2023
@platschi platschi deleted the fix/mobile-and-fill-price branch June 13, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platschi platschi platschi approved these changes

@avclarke avclarke avclarke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeifuChen @platschi @avclarke