Bug/exchange rates #1300
Merged
Bug/exchange rates #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Trying ETH -> sUSD swap clicking "Max" on ETH results in 0 instead of expected max ETH balance of connected wallet
|
|
@platschi the issue is because we "buffer" ETH swaps by 0.1 ETH which seems really extreme. Since the balance is 0.017 it will default to 0, but if you had .2 ETH it would display .1 ETH |
|
Line 1117 in 150de11 |
koredefashokun
approved these changes
Aug 18, 2022
platschi
approved these changes
Aug 18, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix exchange rates on swap for synths that have futures markets (sEUR)
Description
ratesobject in state to include synth and asset names (sEURandEUR)