-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve rate from coinGecko if exchange rate is not found #1291
Conversation
@Xiaolei-Shawn is attempting to deploy a commit to the Kwenta Team on Vercel. A member of the Team first needs to authorize it. |
…ug in rate calculation
943db4f
to
2ab0da3
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Xiaolei-Shawn Kindly check lint errors :) |
My bad! Fixed already. @platschi |
@Xiaolei-Shawn |
@Xiaolei-Shawn The rate of synthetic assets (the assets with the prefix |
…enta into fix-spot-exchange-title
…enta into fix-spot-exchange-title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, works as expected.
Description
coinGecko
if its key is not found inexchangeRates
.newGetExchangeRatesForCurrencies
with wrong order:kwenta/hooks/useExchange.ts
Line 278 in 51068f9
After the fix, we should use
rate
butinverseRate
to render title in exchange pageRelated issue
Issue
Motivation and Context
The title in exchange won't show correct rate if one or both currencies are not found in exchange rates results.
How Has This Been Tested?
Exchange
viewsINR
andDAI
Screenshots (if appropriate):