Add meter endpoint name
#6427
Merged
Add meter endpoint name
#6427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prerequisite for Koenkk/zigbee-herdsman-converters#2273
nurikk
reviewed
Feb 25, 2021
| @@ -41,7 +41,7 @@ const endpointNames = [ | |||
| 'button_11', 'button_12', 'button_13', 'button_14', 'button_15', | |||
| 'button_16', 'button_17', 'button_18', 'button_19', 'button_20', | |||
| 'button_light', 'button_fan_high', 'button_fan_med', 'button_fan_low', | |||
| 'heat', 'cool', 'water', | |||
| 'heat', 'cool', 'water', 'meter', | |||
There was a problem hiding this comment.
We should rethink this mechanism, currently if user adds a new device using external converted with endpoint name not listed here, all underlying logic will fail, we should extract endpoint names from device definitions (respecting external converters)
There was a problem hiding this comment.
Agree, but cannot think of a better solution now. The endpoint is a method so you never know 100% sure what is returned here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite for Koenkk/zigbee-herdsman-converters#2273