Use CMD alongside ENTRYPOINT in the Dockerfile #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for runtime customization, see Koenkk#3362.
|
Hello @pranasziaukas. The base branch of this pull request has been updated to the |
|
Thanks! |
Koenkk
added a commit
that referenced
this pull request
Apr 18, 2020
|
Unfortunately I had to revert this PR because it will break Portainer setups. Thinking a bit better about the Please let me know your use case then we can see if we can figure out something. |
|
Another option is to have a default command on run.sh. if $@ is empty we can set npm start as default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for runtime customization, see #3362.