Update controller.js #1462
Merged
Update controller.js #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use JSON.stringify when outputting Non-JSON to MQTT. When using JSON.stringify strings are quoted in the MQTT messages but they should not be quoted (MQTT is different from JSON).
|
great, thanks! |
wilmardo
pushed a commit
to wilmardo/zigbee2mqtt
that referenced
this pull request
Sep 26, 2019
* Update controller.js Do not use JSON.stringify when outputting Non-JSON to MQTT. When using JSON.stringify strings are quoted in the MQTT messages but they should not be quoted (MQTT is different from JSON). * Update controller.js * Update controller.js * Update controller.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use JSON.stringify when outputting Non-JSON to MQTT. When using JSON.stringify strings are quoted in the MQTT messages but they should not be quoted (MQTT is different from JSON).
I was happy to see the experimental feature to output attributes rather than JSON. Strings where published with quotes to the MQTT topic. Not sure if that is standard for MQTT but as there are no var types in MQTT everything should be handled as a string no matter if they are int, date or string.
Real issue I had:
I pointed openHAB's MQTT binding to the new MQTT topics while having the experimental z2m feature activated but openHAB complained that it didn't know the state '"OFF"' (see the double quotes?).