Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Support effect / effect_list in groups exposed to Home Assistant #13438

Closed
deviantintegral opened this issue Aug 6, 2022 · 6 comments
Labels
feature request Feature request

Comments

@deviantintegral
Copy link
Sponsor Contributor

Is your feature request related to a problem? Please describe

I noticed that I was unable to trigger effects like "okay" and "blink" on my Philips Hue bulbs that are in a group. Targeting individual bulbs worked fine, and sending an effect to a group over MQTT worked as well.

The hint I was missing is that Home Assistant wasn't showing effects in the entity card to control the group:

image

When I manually added effect and effect_list to the device configuration topic, it showed up in the UI and effects worked as expected.

image

Describe the solution you'd like

I think groups should be exposed to Home Assistant with the union of the capabilities of their underlying bulbs. I believe this is the behaviour for attributes like colour and temperature.

Describe alternatives you've considered

It looks like the topic has already reverted and I don't see a way to ensure it stays configured in the long term.

Additional context

Here's a working topic:

{
  "availability": [
    {
      "topic": "zigbee2mqtt/bridge/state"
    },
    {
      "topic": "zigbee2mqtt/Kid's Bathroom/availability"
    }
  ],
  "availability_mode": "all",
  "brightness": true,
  "brightness_scale": 254,
  "color_mode": true,
  "command_topic": "zigbee2mqtt/Kid's Bathroom/set",
  "device": {
    "identifiers": [
      "zigbee2mqtt_1221051039810110150109113116116_5"
    ],
    "name": "Kid's Bathroom",
    "sw_version": "Zigbee2MQTT 1.27.0"
  },
  "effect": true,
  "effect_list": [
    "okay",
    "breathe",
    "blink",
    "channel_change",
    "finish_effect",
    "stop_effect"
  ],
  "max_mireds": 500,
  "min_mireds": 150,
  "name": "Kid's Bathroom",
  "schema": "json",
  "state_topic": "zigbee2mqtt/Kid's Bathroom",
  "supported_color_modes": [
    "xy",
    "color_temp"
  ],
  "unique_id": "5_light_zigbee2mqtt"
}
@deviantintegral deviantintegral added the feature request Feature request label Aug 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale issues label Sep 6, 2022
@deviantintegral
Copy link
Sponsor Contributor Author

not stale

@github-actions github-actions bot removed the stale Stale issues label Sep 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale issues label Oct 7, 2022
@deviantintegral
Copy link
Sponsor Contributor Author

not stale!

@github-actions github-actions bot removed the stale Stale issues label Oct 8, 2022
@Koenkk
Copy link
Owner

Koenkk commented Oct 8, 2022

not stale but closed! implemented 😄

Changes will be available in the dev branch in a few hours from now. (https://www.zigbee2mqtt.io/advanced/more/switch-to-dev-branch.html)

@Koenkk Koenkk closed this as completed Oct 8, 2022
@deviantintegral
Copy link
Sponsor Contributor Author

This is working well for me. I even have a group of Hue and non-Hue bulbs that don't support effects, and I can send an effect to the group and if the bulb supports it, it executes. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

2 participants