bare minimum fix for #117 issue #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasCresson
pushed a commit
to thomasCresson/g3sinks
that referenced
this pull request
Jan 3, 2022
Updating the CMakeLists.txt in order to download googletest only when CHOICE_BUILD_TESTS or CHOICE_BUILD_EXAMPLES are set to ON.
|
Hi @KjellKod, I submitted a pull request to address the problem of downloading google-test even when it's not needed (I probably didn't reference the good issue on my commit message sorry ><). |
|
It's all good. I've seen it just haven't had time to test it. It looks good and I think it will be merged today or tomorrow if all works out |
KjellKod
pushed a commit
that referenced
this pull request
Jan 6, 2022
Updating the CMakeLists.txt in order to download googletest only when CHOICE_BUILD_TESTS or CHOICE_BUILD_EXAMPLES are set to ON. Co-authored-by: Thomas CRESSON <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: URL link #117