Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retransmission count are not consistent with the real value on Linux 4.7 or higher #450

Merged
merged 11 commits into from
Feb 24, 2023
Merged

Fix retransmission count are not consistent with the real value on Linux 4.7 or higher #450

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
caa4264
fix: get `segs` from the retransmit event
NeJan2020 Feb 14, 2023
35793a0
fix: read segs from retransmit event
NeJan2020 Feb 14, 2023
532b950
ci: update agent-libs
NeJan2020 Feb 14, 2023
147a80c
feat: add debug log for tcpMetricAnalyzer's output
NeJan2020 Feb 14, 2023
572930f
fix: fix tcpMetricAnalyzer debug level
NeJan2020 Feb 15, 2023
e34122e
doc: update change log
NeJan2020 Feb 15, 2023
ec70565
Merge commit '135854671072c9770f2144d5ac5db88e444fc8d6' into fix-retr…
NeJan2020 Feb 21, 2023
06df5f8
doc: update kindling_tcp_retransmit_total metric
NeJan2020 Feb 21, 2023
63dd1b7
doc: fix typo
NeJan2020 Feb 24, 2023
e13d420
doc: fix typo
NeJan2020 Feb 24, 2023
c9cd831
ci: update agent-lib
NeJan2020 Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: read segs from retransmit event 
Signed-off-by: niejiangang <[email protected]>
  • Loading branch information
@NeJan2020
NeJan2020 committed Feb 14, 2023
commit 35793a081be636beae27806aada1ba6f6e166294
9 changes: 8 additions & 1 deletion collector/pkg/component/analyzer/tcpmetricanalyzer/tcp_analyzer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,14 @@ func (a *TcpMetricAnalyzer) generateRetransmit(event *model.KindlingEvent) (*mod
if err != nil {
return nil, err
}
metric := model.NewIntMetric(constnames.TcpRetransmitMetricName, 1)

var segs = int64(1)
p_segs := event.GetUserAttribute("segs")
if p_segs != nil && p_segs.GetValueType() == model.ValueType_INT32 {
segs = p_segs.GetIntValue()
}

metric := model.NewIntMetric(constnames.TcpRetransmitMetricName, segs)
return model.NewDataGroup(constnames.TcpRetransmitMetricGroupName, labels, event.Timestamp, metric), nil
}

Expand Down