vk.xml: Include vk_platform type-header from vulkan/vk_platform.h
#1538
Conversation
It is generally expected that "top level" includes are relative to the `./include` directory in this repo. The video headers, sitting at the root of the `./include` folder in `./include/vk_video/vulkan_video_*.h`, are listed as `vk_video/vulkan_video_*.h` in `vk.xml`. Likewise the `vk_platform` type-header is supposed to be listed as `vulkan/vk_platform.h` to match its relative location under `./include`.
|
|
|
That's pretty weird actually. I think |
I agree, created #1541 for it to track this separately for follow-up with the Video folks. |
|
@zlatinski Video TSG should sign off on this one. |
|
@oddhack I don't think |
OK. We'll take a look at it internally. It usually takes a lot of back-and-forthing between the different downstream components like the SDK before everyone signs off on even a simple change like this, so I wouldn't expect a quick response. |
|
We talked about this briefly and are OK with taking it, but not until after next week's updates for internal scheduling reasons. |
Great, thanks for that and thanks for keeping this issue updated! |
|
We are expecting Vulkan Video apps to add to the include paths both ..include/vk_video and ..include/vulkan, assuming the app is not using header file name spaces. The prefered way,, however, would be to only include the top level ../include path. The app, in this case should use the appropriate NS directories along with the included header file. |
|
@zlatinski Totally, that makes the most sense. When looking at |
* generator: Fix Rust 1.53 clippy lints * temporary: Allow bindgen nullptr dereference in layout tests * Update Vulkan-Headers to 1.2.182 * extensions/ext: Add properties-getter for PhysicalDeviceDrmPropertiesEXT * Update Vulkan-Headers to 1.2.183 * Remove upstream-fixed vk_platform.h header path fallback Fixed in KhronosGroup/Vulkan-Docs#1538 * Update Vulkan-Headers to 1.2.184
This caused some issues with search paths per #1573. There will probably be a downstream change to move the vk_video/ headers under vulkan/vk_video instead of in a parallel directory. We are not entirely settled on how to move this forward at the moment and there's a mix of philosophical correctness and concrete build issues being discussed in
This caused some issues with search paths per #1573. There will probably be a downstream change to move the vk_video/ headers under vulkan/vk_video instead of in a parallel directory. We are not entirely settled on how to move this forward at the moment and there's a mix of philosophical correctness and concrete build issues being discussed in
It is generally expected that "top level" includes are relative to the
./includedirectory in this repo. The video headers, sitting at the root of the./includefolder in./include/vk_video/vulkan_video_*.h, are listed asvk_video/vulkan_video_*.hinvk.xml. Likewise thevk_platformtype-header is supposed to be listed asvulkan/vk_platform.hto match its relative location under./include.