Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit the debug instructions in WebGPU SPIR-V #3063

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Permit the debug instructions in WebGPU SPIR-V #3063

merged 2 commits into from
Nov 26, 2019

Conversation

sarahM0
Copy link
Contributor

@sarahM0 sarahM0 commented Nov 21, 2019

Implementing: gpuweb/spirv-execution-env#40
Reverting parts of : #2089

dneto0
dneto0 requested changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@dneto0 dneto0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the tests to prove that the WebGPU environment actually accepts those instructions.

@sarahM0 sarahM0 requested a review from dneto0 November 25, 2019 18:06
@dneto0 dneto0 merged commit 8312c52 into KhronosGroup:master Nov 26, 2019
@sarahM0 sarahM0 mentioned this pull request Dec 2, 2019
Merged
dj2 pushed a commit that referenced this pull request Dec 3, 2019
@sarahM0 @dj2
Permit the debug instructions in WebGPU SPIR-V - remove from the opti…
0a5d99d 
…mizer (#3083)

continuing #3063
fixing #3052
@zoddicus zoddicus mentioned this pull request Dec 16, 2019
Closed
dneto0 pushed a commit to dneto0/SPIRV-Tools that referenced this pull request Sep 14, 2024
@zoddicus
Rolling 4 dependencies & updating expectations (KhronosGroup#929)
67cc6cb 
Roll third_party/glslang/ 38b4db4..0de87ee (6 commits)

KhronosGroup/glslang@38b4db4...0de87ee

$ git log 38b4db4..0de87ee --date=short --no-merges --format='%ad %ae %s'
2019-12-04 rnk Remove glslang::pool_allocator::setAllocator
2019-01-21 ian.d.romanick INTEL_shader_integer_functions2: Add SPIR-V generation
2018-09-20 ian.d.romanick INTEL_shader_integer_functions2: Add compiler front-end support
2018-09-20 ian.d.romanick INTEL_shader_integer_functions2: Add basic extension tracking
2019-12-02 ian.d.romanick Update README.md to include other test requirements
2019-11-27 malcolm.bechard Fix KhronosGroup#1981

Roll third_party/googletest/ 679bfec6d..ae8d1fc81 (14 commits)

google/googletest@679bfec...ae8d1fc

$ git log 679bfec6d..ae8d1fc81 --date=short --no-merges --format='%ad %ae %s'
2019-12-02 absl-team Googletest export
2019-11-27 Oleksandr.Yefremov Rename test case to test suite
2019-11-26 absl-team Googletest export
2019-11-25 absl-team Googletest export
2019-11-25 mate.pek README.md: added Catch2 and Google Test Explorer
2019-11-25 maximilianschwab Fixed typo
2019-11-17 krystian.kuzniarek unify googletest and googlemock main functions
2019-11-17 krystian.kuzniarek remove MSVC workaround: wmain link error in the static library
2019-11-22 krystian.kuzniarek remove Nokia's Symbian compiler workaround: SafeMatcherCastImpl
2019-11-22 krystian.kuzniarek consistency fix for SafeMatcherCastImpl member functions
2019-11-14 krystian.kuzniarek remove MSVC workaround: accessing namespace scope from within nested classes
2019-11-22 krystian.kuzniarek remove g++ 3.3 workaround: using on operator<<
2019-11-21 Christoph.Strehle Fix compile break for Microsoft Visual Studio 2017 v141
2019-11-05 krystian.kuzniarek change incorrect comments

Roll third_party/spirv-cross/ fd5aa3ad5..15b860eb1 (15 commits)

KhronosGroup/SPIRV-Cross@fd5aa3a...15b860e

$ git log fd5aa3ad5..15b860eb1 --date=short --no-merges --format='%ad %ae %s'
2019-12-04 post Remove obsolete use of AtomicCounterMemoryMask.
2019-12-04 post Don't emit memoryBarrierShared() in workgroup control barriers.
2019-12-03 dsinclair Update graphics robust access results
2019-12-03 post Fix MSVC warnings when building without exceptions.
2019-12-03 dsinclair Share test shader script
2019-12-03 post Update update_test_shaders.sh as well.
2019-12-02 dsinclair Roll SPIRV-Tools, SPIRV-Headers and GLSLang
2019-12-02 post Fix uninitialized memory issue.
2019-12-02 post MSL: Support ClipDistance as an input stage variable.
2019-11-28 post Fix sign handling for S/UToF.
2019-11-28 post MSL: Fix automatic binding allocation for image atomic buffers.
2019-11-27 agaule Added --msl-decoration-binding command line argument to enable binding decoration for Metal.
2019-11-26 sarahmashay Add licensing header to test_shaders.py
2019-11-26 post Mark loop headers as complex as early as possible.
2019-11-25 bill.hollings Expose as public Compiler::update_active_builtins() and has_active_builtin().

Roll third_party/spirv-tools/ 85f3e93..e82a428 (13 commits)

KhronosGroup/SPIRV-Tools@85f3e93...e82a428

$ git log 85f3e93..e82a428 --date=short --no-merges --format='%ad %ae %s'
2019-12-03 dneto WebGPU: Array size at most max signed int + 1 (KhronosGroup#3077)
2019-12-03 9856269+sarahM0 Permit the debug instructions in WebGPU SPIR-V - remove from the optimizer (KhronosGroup#3083)
2019-12-03 dneto graphics robust access: use signed clamp (KhronosGroup#3073)
2019-12-02 stevenperron Folding: perform add and sub on mismatched integer types (KhronosGroup#3084)
2019-11-29 afdx spirv-fuzz: Fix invalid tests (KhronosGroup#3079)
2019-11-27 alanbaker Validate nested constructs (KhronosGroup#3068)
2019-11-27 afdx spirv-fuzz: Improve debugging facilities (KhronosGroup#3074)
2019-11-27 stevenperron Handle unreachable block when computing register pressure (KhronosGroup#3070)
2019-11-27 greg Improve RegisterSizePasses (KhronosGroup#3059)
2019-11-26 headlessclayton utils/vscode: Add install.bat (KhronosGroup#3071)
2019-11-26 52076061+digit-google build: cmake: Add support for Fuchsia. (KhronosGroup#3062)
2019-11-26 dneto Add test with explicit example of stripping reflection info (KhronosGroup#3064)
2019-11-26 9856269+sarahM0 Permit the debug instructions in WebGPU SPIR-V (KhronosGroup#3063)

Created with:
  roll-dep third_party/effcee third_party/glslang third_party/googletest third_party/re2 third_party/spirv-cross third_party/spirv-headers third_party/spirv-tools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dneto0 dneto0 dneto0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sarahM0 @dneto0