Cleanup is tons of fun

Khan · Oct 4, 2024 · 5f748f1 · 5f748f1
1 parent fe0bef1
commit 5f748f1
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 9 deletions.
diff --git a/packages/perseus/src/widgets/interactive-graph.tsx b/packages/perseus/src/widgets/interactive-graph.tsx
@@ -2352,7 +2352,7 @@ class InteractiveGraph extends React.Component<Props, State> {
             throw makeInvalidTypeError("getAngleEquationString", "angle");
         }
         const coords = InteractiveGraph.getAngleCoords(props.graph, props);
-        const allowReflexAngles = props.graph.allowReflexAngles || false;
+        const allowReflexAngles = props.graph.allowReflexAngles;
         const angle = getClockwiseAngle(coords, allowReflexAngles);
         return (
             angle.toFixed(0) +

diff --git a/packages/perseus/src/widgets/interactive-graphs/graphs/components/angle-indicators.test.ts b/packages/perseus/src/widgets/interactive-graphs/graphs/components/angle-indicators.test.ts
@@ -101,7 +101,6 @@ describe("shouldDrawArcOutside", () => {
         const point2 = [2, 0] as vec.Vector2;
         const vertex = [0, 0] as vec.Vector2;
         const coords: [Coord, Coord, Coord] = [point1, vertex, point2];
-        const allowReflexAngles = false;
-        expect(getClockwiseAngle(coords, allowReflexAngles)).toBe(45);
+        expect(getClockwiseAngle(coords)).toBe(45);
     });
 });
diff --git a/packages/perseus/src/widgets/interactive-graphs/interactive-graph-validator.ts b/packages/perseus/src/widgets/interactive-graphs/interactive-graph-validator.ts
@@ -257,7 +257,7 @@ function interactiveGraphValidator(
         ) {
             const guess = userInput.coords;
             const correct = rubric.correct.coords;
-            const allowReflexAngles = rubric.correct.allowReflexAngles || false;
+            const allowReflexAngles = rubric.correct.allowReflexAngles;
 
             let match;
             if (rubric.correct.match === "congruent") {

diff --git a/packages/perseus/src/widgets/interactive-graphs/math/angles.ts b/packages/perseus/src/widgets/interactive-graphs/math/angles.ts
@@ -43,7 +43,7 @@ export const getAngleFromVertex = (
 // current angle for the interactive graph.
 export const getClockwiseAngle = (
     coords: [Coord, Coord, Coord],
-    allowReflexAngles: boolean,
+    allowReflexAngles: boolean = false,
 ): number => {
     const coordsCopy = [...coords];
     // The coords are saved as [point1, vertex, point2] in the interactive graph

diff --git a/packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-reducer.test.ts b/packages/perseus/src/widgets/interactive-graphs/reducer/interactive-graph-reducer.test.ts
@@ -462,10 +462,7 @@ describe("movePoint on an angle graph", () => {
         invariant(updated.type === "angle");
 
         expect(
-            getClockwiseAngle(
-                updated.coords,
-                updated.allowReflexAngles || false,
-            ),
+            getClockwiseAngle(updated.coords, updated.allowReflexAngles),
         ).toBeCloseTo(50);
     });