Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Comrade v0.11.0 #116695

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

## Breaking Changes
- Comrade is now only ADable with Enzyme
- to specify the AD mode use the `admode` kwarg in the `VLBIPosterior` constructor
- Only support Julia versions 1.10 and later
- Enzyme is an extension now and must be loaded before trying to take a derivative
- Can no longer specify `adtype` in `sample` and `comrade_opt` calls. The AD is specified in `VLBIPosterior`
- Removed a large number of rules since they are no longer needed


## New features
- Added `instrumentmodel(post, x)` method that will produce the full Jones matrix for the instrument
- Added `forward_jones(J, instrument)` to create specific instrumental Jones matrices given some instrument parameters
- Added `corr_image_prior` to automatically construct a correlated image prior for imaging


## Updates
- Added a `Pigeons` docs page
- Changed polarized example to make an image of M87*
- Removed a large number of unused files
- More `EnzymeRules.inactive` calls
- Fixed `datatable` so that it preserves SOA
- Tried to remove anonymous functions since they don't serialize well.

UUID: 99d987ce-9a1e-4df8-bc0b-1ea019aa547b
Repo: https://github.com/ptiede/Comrade.jl.git
Tree: b35d823d152a6a3f401ed956314df4a0a5540b92

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
Copy link
Contributor

github-actions bot commented Oct 6, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round.

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit 63f1949 into master Oct 6, 2024
22 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-comrade-99d987ce-v0.11.0-f695ae85fa branch October 6, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants