Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version: StableHashTraits v1.3.1 #116600

Merged
merged 1 commit into from
Oct 4, 2024
Merged

New version: StableHashTraits v1.3.1 #116600

merged 1 commit into from
Oct 4, 2024

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator
New version: StableHashTraits v1.3.1
4e78fc7 
UUID: c5dd0088-6c3f-4803-b00e-f31a60c170fa
Repo: https://github.com/beacon-biosignals/StableHashTraits.jl.git
Tree: c03b774a9ec8ea0df791d586021819d3873cb610

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
JuliaRegistrator referenced this pull request in beacon-biosignals/StableHashTraits.jl Oct 4, 2024
@haberdashPI
Support Julia 1.11 (hash version=4 only). (#69)
8d5f71c 
Julia hash versions 1-3 have a number of components that make them unstable when Julia upgrades and in fact, they break sometimes when being compiled under Julia 1.11. (In normal use I seem to be able to call versions 1-3, but the tests fail in various ways that look like they are related to generated functions). We've just built a new hash version that should be much more stable and work on Julia 1.11 (#58), and the maintenance burden of keeping 1-3 working on newer Julia versions isn't something I have the bandwidth for.

Running tests in 1.11 also revealed a subtle bug in buffering, based on a I misunderstanding I had about the `IOBuffer` API. From what I can tell this did not lead to any correctness issues on earlier versions (because I was carefully resetting buffer state to make sure buffer positions lined up with the start of the array), but I was not following public API, and so it broke on 1.11. This was fixed by using `take!` instead of the gymnastics I was going through before.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. AutoMerge Guidelines are all met! ✅

Your new version registration met all of the guidelines for auto-merging and is scheduled to be merged in the next round.

2. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

@JuliaTagBot JuliaTagBot merged commit e7aed6c into master Oct 4, 2024
17 checks passed
@JuliaTagBot JuliaTagBot deleted the registrator-stablehashtraits-c5dd0088-v1.3.1-34a4eefbce branch October 4, 2024 13:57
@JuliaTagBot JuliaTagBot mentioned this pull request Oct 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuliaRegistrator @JuliaTagBot