-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: AppleHealthParser v1.0.0 #116443
base: master
Are you sure you want to change the base?
New package: AppleHealthParser v1.0.0 #116443
Conversation
JuliaRegistrator
commented
Oct 2, 2024
•
edited
Loading
edited
- Registering package: AppleHealthParser
- Repository: https://github.com/sumant-28/AppleHealthParser.jl
- Created by: @sumant-28
- Version: v1.0.0
- Commit: fe833a153c69d32c91d15384a913a4b5ef656e77
- Reviewed by: @sumant-28
- Reference: sumant-28/AppleHealthParser.jl@fe833a1#commitcomment-147469311
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human. 1. New package registrationPlease make sure that you have read the package naming guidelines. 2. AutoMerge Guidelines are all met! ✅Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed. 3. To pause or stop registrationIf you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text Tip: You can edit blocking comments to add |
Hi @sumant-28, this seems to be only your second attempt to register a package in the General registry. For this reason, and also because you asked on Slack about unit tests, let me leave a few comments about how you could (and probably should) improve your package to make it more suitable for registration in General:
There is probably more to say but these are the most important points. Note that not all of them are mandatory for the registration to go through - we have few strict requirements for packages - but I strongly recommend that you try to implement these suggestions. [noblock] |
UUID: d1ed7681-0bdc-4b3e-a64e-a9a059b3ebfe Repo: https://github.com/sumant-28/AppleHealthParser.jl.git Tree: 1122044ed21e54fa8ba62ada326329427c92b02b Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
b77ecec
to
f15c6b8
Compare
Hi @sumat-28, did you see my comments above? Especially point 1) would be important to improve to make your package suitable for registration in General, at least in my opinion. |
With some minor fixes, this should be totally fine to register… but it is definitely not yet at the level of maturity required for a 1.0 version. So I would ask to change the version number to 0.1 in addition to considering some of the other comments |