Revise the API of is_manifest_current. #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
IanButterworth
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
Seems good to me. There don't seem to be any public users of the function, so this shouldn't be too bad of a breaking bugfix, I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API function
is_manifest_currentwas not working as intended and was mostly useless for its intended purpose of verifying in tests that the manifest and project files of a package were synchronized. See#2815 (comment) for details.
This PR removes the zero-argument method of
is_manifest_currentand adds a newis_manifest_current(::AbstractString)method that can be used in tests in, e.g., the form