Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project hash to manifest metadata and warn when manifest and project are out of sync #2815

Merged
merged 12 commits into from
Nov 11, 2021
Merged

Add project hash to manifest metadata and warn when manifest and project are out of sync #2815

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
09e0dc5
add project hash to manifest metadata. add is_manifest_current
IanButterworth Nov 1, 2021
ad7667f
precompile: don't instantiate again after an instantiate
IanButterworth Nov 1, 2021
2681963
use SHA1
IanButterworth Nov 1, 2021
818ed58
add warning to Pkg.status
IanButterworth Nov 1, 2021
cd1b92c
fix imports
IanButterworth Nov 1, 2021
d8d542b
add tests
IanButterworth Nov 2, 2021
2ba7095
Apply suggestions from code review
IanButterworth Nov 3, 2021
7c4241d
update warning message
IanButterworth Nov 3, 2021
1e161ff
fix ios
IanButterworth Nov 3, 2021
bb6b438
better message
IanButterworth Nov 4, 2021
af82fea
Update CHANGELOG.md
IanButterworth Nov 11, 2021
d24f0fb
Update CHANGELOG.md
IanButterworth Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Fredrik Ekre <[email protected]>
  • Loading branch information
@IanButterworth @fredrikekre
IanButterworth and fredrikekre authored Nov 3, 2021
commit 2ba709546264b493e0d265d4174916abfff3734f
5 changes: 2 additions & 3 deletions src/Types.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ Base.@kwdef mutable struct Compat
val::VersionSpec
str::String
end
Base.hash(t::Compat, h::UInt) = foldr(hash, [t.val, t.str], init=h)

Base.@kwdef mutable struct Project
other::Dict{String,Any} = Dict{String,Any}()
Expand All @@ -240,8 +239,8 @@ Base.hash(t::Project, h::UInt) = foldr(hash, [getfield(t, x) for x in fieldnames
# only hash the deps and compat fields as they are the only fields that affect a resolve
function project_resolve_hash(t::Project, h::UInt = UInt(0))
iob = IOBuffer()
println(iob, t.deps)
println(iob, t.compat)
foreach(((name, uuid),) -> println(io, name, "=", uuid), sort!(collect(t.deps); by=first))
foreach(((name, compat),) -> println(name, "=", compat.val), sort!(collect(t.compat); by=first))
return bytes2hex(sha1(seekstart(iob)))
end

Expand Down