Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compat]: ImageCore/Transformations/Binarization #1035

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Jul 22, 2023

Closes #1032
Closes #1033
Closes #1034

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9528c79) 87.24% compared to head (23a1647) 87.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files           6        6           
  Lines         674      674           
=======================================
  Hits          588      588           
  Misses         86       86           
Impacted Files Coverage Δ
src/deprecations.jl 87.08% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timholy
Copy link
Member Author

timholy commented Jul 22, 2023

We seem to be getting close to last call for the next release, any reasons to hold off? A motivation for doing it soon is simply to have consistent versions across the ecosystem (less precompiling...) for the JuliaCon workshop, but we can hold off if there are good reasons.

There's less breaking/deprecated stuff by far than for 0.25; in a sense the only thing breaking is ImageCore (https://github.com/JuliaImages/ImageCore.jl/blob/master/NEWS.md). Since Images.jl is sort of a "front" for ImageCore, that might be enough reason for a breaking release. But I recently learned that just dropping old Julia versions does not require a minor version bump for 0.x releases, so in principle this could be 0.25.4. Thoughts?

@timholy timholy merged commit 4854014 into master Jul 22, 2023
12 checks passed
@timholy timholy deleted the teh/compat branch July 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant