Fix Utilities.submodules for module aliases #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Oct 9, 2018
test/utilities.jl
Outdated
| @@ -35,6 +35,17 @@ export OuterModule | |||
| end | |||
| end | |||
|
|
|||
| module ModuleWithAlias | |||
| using LinearAlgebra | |||
There was a problem hiding this comment.
Create another test module instead? I believe this will pull in LinearAlgebra and Random as dependencies, which is not optimal.
There was a problem hiding this comment.
Done. I do think there should be a module that's its own parent as a test case, so I'm using Main for that now.
tkoolen
force-pushed
the
tk/fix-submodules-alias
branch
from
a920da1
to
d9cd1b9
Compare
tkoolen
force-pushed
the
tk/fix-submodules-alias
branch
from
d9cd1b9
to
59302a3
Compare
mortenpi
changed the title
mortenpi
changed the title
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #851