Allow whitelisting links in linkcheck #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, this looks like it'll do, thanks much. If you can get out a new release in a week or so, it can be part of rc2 instead of rc1 if needed. |
While we may not want to make the part of the public long-term API, we should still document their behaviour.
This allows certain URLs to be whitelisted in linkcheck. Fixes #447.
Some of the links in the manual have become out of date. Optim.jl does not seem to be using Documenter actively at the moment (no recent builds).
|
If I'd say I'll do a release by Friday, would that be fast enough for rc1? |
|
rc1 will probably be before next friday, but doesn't absolutely need this to be available yet |
|
Maybe that was ambitious. If someone hadn't broken the build on power, we'd probably have rc1 already. Anyway, put to good use in JuliaLang/julia@0afcf05. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tkelman apologies for being a bit passive on the Documenter front at the moment. I assumed this to be a "nice to have".
I think adding another keyword argument would do the trick. This more or less copies how this is done in Sphinx as far as I can tell.
This will require a minor version bump, so I am thinking it might be time to merge a couple of the other PRs as well while we're at it. How fast would you like to have this available?
Fixes #447.