-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init Testing Chapter #87
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds good! |
…e more featureful
…tter communication moving forward)
…pl-treasury, and minimize readme length
…dding on_initialize as well && added changelog
4meta5
commented
Nov 29, 2019
4meta5
commented
Nov 29, 2019
JoshOrndorff
reviewed
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few significant changes. At this point, it is ready for review.
CHANGELOG
It adds a
CHANGELOG.md
at the root. This file is intended to serve as aCHANGELOG
similar to libp2p's changelog. It might track the growth of the recipes and reorganization of content.In the long-run, it provides a transparent record of how things have changed without requiring that much buy in by the contributors; there should be no mandatory enforcement. When enough work has been done to warrant some bullets, this is better than nothing.
Testing Section
The new testing section is split up into three sections:
The best way to review might be to checkout the branch and
mdbook build --open
. I'm eager to merge this, but am also open to review. I rewrote a lot of the code while testing, which makes a lot of sense. I started writing about theexecution-schedule
example in greater depth here but I don't want to include it in this PR. I'll bring it into a future one.other
Instead of
rust
for code block annotations, I changed it torust, ignore
so that it doesn't give users the option to try to compile (which we know doesn't work for substrate code). I actually consider this to be a pretty huge win for UX (DX).