Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"True" Mirrored Mode #876

Merged
merged 3 commits into from
Dec 6, 2019
Merged

"True" Mirrored Mode #876

merged 3 commits into from
Dec 6, 2019

Conversation

justMaku
Copy link
Contributor

@justMaku justMaku commented Oct 17, 2019

This PR add support to "true" mirrored mode where the image on odd displays is flipped horizontally. The old "mirrored" mode has been renamed to "cloned".

Existing users will have to manually switch to the new mirroring behavior otherwise they will stay in the old mode.

Here's some previews:
Screenshot 2019-10-17 at 13 30 48
Screenshot 2019-10-17 at 13 30 45

@glouel
Copy link
Collaborator

glouel commented Oct 17, 2019

Hi @justMaku !

Thanks a lot for the PR, this looks pretty cool ! I'm going to be pretty busy in the coming days so I may not be able to merge and release a new version until monday.

I saw you put the new mirrored at the end of the enum so that's great, it won't mess with current user's settings.

One thing come to mind, it looks like you're using the index in which the system has called us. Off the top of my head, we're called on main screen first then the other screens. But it's not position dependant. If you had an iMac with one screen on the right, and one on the left, you'd want main (0) normal, and 1 and 2 flipped too to keep the effect.

I'm not sure that's a big issue as the number of complex screen configuration users is pretty small, and they may not want a double flipping anyway in that case I mentionned (may look a bit jarring unlike a 2 way mirror effect which looks pretty cool I think).

I do have some code to detect screen's relative position but it's a big mess because you can have screens in 2 directions with overlap, so I'd avoid going in there. And in the same way, if vertical mirroring, I'm not sure flipping would be good, that would truly be jarring ;)

So I'd say let's add it as is, and if people with more complex configurations wants more, it can always be perfected a bit.

Thanks again!

@glouel
Copy link
Collaborator

glouel commented Dec 6, 2019

Well, didn't hear back from you but merging as is.

@glouel glouel merged commit 59bf700 into JohnCoates:master Dec 6, 2019
czo pushed a commit to czo/Aerial that referenced this pull request Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants