Skip to content

Commit

Permalink
Merge pull request ceph#26219 from yaozongyou/mon-cleanups
Browse files Browse the repository at this point in the history
mon: some tiny cleanups related class forward declaration

Reviewed-by: Kefu Chai <[email protected]>
Reviewed-by: Patrick Donnelly <[email protected]>
  • Loading branch information
jecluis committed Feb 27, 2019
2 parents bc9ac5a + d518714 commit bde0ea9
Show file tree
Hide file tree
Showing 10 changed files with 0 additions and 33 deletions.
2 changes: 0 additions & 2 deletions src/mon/AuthMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@
#include "mon/PaxosService.h"
#include "mon/MonitorDBStore.h"

class MMonCommand;
struct MAuth;
struct MMonGlobalID;
class KeyRing;
class Monitor;

Expand Down
3 changes: 0 additions & 3 deletions src/mon/ConfigKeyService.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@

class Paxos;
class Monitor;
namespace ceph {
class Formatter;
}

class ConfigKeyService : public QuorumService
{
Expand Down
3 changes: 0 additions & 3 deletions src/mon/HealthMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@

#include "mon/PaxosService.h"

//forward declaration
namespace ceph { class Formatter; }

class HealthMonitor : public PaxosService
{
version_t version = 0;
Expand Down
1 change: 0 additions & 1 deletion src/mon/LogMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
#include "common/LogEntry.h"
#include "include/str_map.h"

class MMonCommand;
class MLog;

static const string LOG_META_CHANNEL = "$channel";
Expand Down
3 changes: 0 additions & 3 deletions src/mon/MDSMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,6 @@
#include "msg/Messenger.h"
#include "messages/MMDSBeacon.h"

class MMonCommand;
class MMDSLoadTargets;
class MMDSMap;
class FileSystemCommandHandler;

class MDSMonitor : public PaxosService, public PaxosFSMap {
Expand Down
2 changes: 0 additions & 2 deletions src/mon/MgrMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,6 @@ class MgrMonitor: public PaxosService
void count_metadata(const string& field, Formatter *f);
void count_metadata(const string& field, std::map<string,int> *out);

friend class C_Updated;

// When did the mon last call into our tick() method? Used for detecting
// when the mon was not updating us for some period (e.g. during slow
// election) to reset last_beacon timeouts
Expand Down
2 changes: 0 additions & 2 deletions src/mon/MgrStatMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,4 @@ class MgrStatMonitor : public PaxosService {
bool verbose) const {
digest.dump_pool_stats_full(osdm, ss, f, verbose);
}

friend class C_Updated;
};
1 change: 0 additions & 1 deletion src/mon/MonClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ class MMonGetVersionReply;
struct MMonSubscribeAck;
class MMonCommandAck;
struct MAuthReply;
class MAuthRotating;
class LogClient;
class AuthAuthorizer;
class AuthClientHandler;
Expand Down
12 changes: 0 additions & 12 deletions src/mon/Monitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -102,18 +102,6 @@ class PaxosService;
class PerfCounters;
class AdminSocketHook;

class MMonGetMap;
class MMonGetVersion;
class MMonMetadata;
class MMonSync;
class MMonScrub;
class MMonProbe;
struct MMonSubscribe;
struct MRoute;
struct MForward;
struct MTimeCheck2;
struct MMonHealth;

#define COMPAT_SET_LOC "feature_set"

class C_MonContext final : public FunctionContext {
Expand Down
4 changes: 0 additions & 4 deletions src/mon/MonmapMonitor.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
#include "MonMap.h"
#include "MonitorDBStore.h"

class MMonMap;
class MMonCommand;
class MMonJoin;

class MonmapMonitor : public PaxosService {
public:
MonmapMonitor(Monitor *mn, Paxos *p, const string& service_name)
Expand Down

0 comments on commit bde0ea9

Please sign in to comment.