Fix encoding of project name in doc url #2851
Open
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JavaDocExternalFilter.getExternalDocInfoForElement does a comparison to determine if the given doc URL is coming from the built in server. However, it does this using a constructed string that fails to correctly encode the project name, so the comparison does not work for any project names that contains characters needing encoding (like a space). Using Urls.newHttpUrl() to make the comparison string fixes the issue, since this is the same API used in BuiltInWebBrowserUrlProvider to create the doc URL in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaDocExternalFilter.getExternalDocInfoForElement does a comparison to determine if the given doc URL is coming from the built in server. However, it does this using a constructed string that fails to correctly encode the project name, so the comparison does not work for any project names that contains characters needing encoding (like a space).
Using Urls.newHttpUrl() to make the comparison string fixes the issue, since this is the same API used in BuiltInWebBrowserUrlProvider to create the doc URL in the first place.