Skip to content

Commit

Permalink
[media] media: usb: s2255: s2255drv: don't print error when allocatin…
Browse files Browse the repository at this point in the history
…g urb fails

kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
  • Loading branch information
Wolfram Sang authored and mchehab committed Aug 24, 2016
1 parent 59b5d24 commit fc56da7
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions drivers/media/usb/s2255/s2255drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -2113,11 +2113,8 @@ static int s2255_start_readpipe(struct s2255_dev *dev)
pipe_info->state = 1;
pipe_info->err_count = 0;
pipe_info->stream_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!pipe_info->stream_urb) {
dev_err(&dev->udev->dev,
"ReadStream: Unable to alloc URB\n");
if (!pipe_info->stream_urb)
return -ENOMEM;
}
/* transfer buffer allocated in board_init */
usb_fill_bulk_urb(pipe_info->stream_urb, dev->udev,
pipe,
Expand Down Expand Up @@ -2290,10 +2287,8 @@ static int s2255_probe(struct usb_interface *interface,
}

dev->fw_data->fw_urb = usb_alloc_urb(0, GFP_KERNEL);
if (!dev->fw_data->fw_urb) {
dev_err(&interface->dev, "out of memory!\n");
if (!dev->fw_data->fw_urb)
goto errorFWURB;
}

dev->fw_data->pfw_data = kzalloc(CHUNK_SIZE, GFP_KERNEL);
if (!dev->fw_data->pfw_data) {
Expand Down

0 comments on commit fc56da7

Please sign in to comment.