Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HID: core: move Usage Page concatenation to Main item
[ Upstream commit 58e75155009cc800005629955d3482f36a1e0eec ] As seen on some USB wireless keyboards manufactured by Primax, the HID parser was using some assumptions that are not always true. In this case it's s the fact that, inside the scope of a main item, an Usage Page will always precede an Usage. The spec is not pretty clear as 6.2.2.7 states "Any usage that follows is interpreted as a Usage ID and concatenated with the Usage Page". While 6.2.2.8 states "When the parser encounters a main item it concatenates the last declared Usage Page with a Usage to form a complete usage value." Being somewhat contradictory it was decided to match Window's implementation, which follows 6.2.2.8. In summary, the patch moves the Usage Page concatenation from the local item parsing function to the main item parsing function. Change-Id: Icefeed2a2b29c5d8a5488617af325d100ba9fbdb Signed-off-by: Nicolas Saenz Julienne <[email protected]> Reviewed-by: Terry Junge <[email protected]> Signed-off-by: Benjamin Tissoires <[email protected]> Signed-off-by: Sasha Levin <[email protected]> Git-commit: 69f6720 Git-repo: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git [[email protected]: resolved trivial conflict in drivers/hid/hid-core.c] Signed-off-by: Ivaylo Georgiev <[email protected]>
- Loading branch information