-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Japanese content to translation/ja
#452
Conversation
…nnerSourcePatterns into book-jp-folder-move
@yuhattor could you review this again? Now using When reviewing this, could you also double check the documentation, to make sure that we are explaining correctly how this all works? Thanks :) Btw I would already go ahead and change the URL on Production to |
Thank you! It's amazing:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm:)
This PR contributes to a part of #430.
I moved all files from
translation/japanese
totranslation/ja
and adapted scripts and docs that contained the old folder name.By changing this folder name things are more consistent with branch names (
book-ja
) the other book files (/book/ja
) etc.Deployed a staging version of this to:
https://innersourcecommons.gitbook.io/innersource-patterns-staging/v/ja-test/
As part of this I also improved the GHA workflow.
Now any folder starting with
book-ja
will generate the Japanese book, which should be helpful for testing purposes.