Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Japanese content to translation/ja #452

Merged
merged 10 commits into from
Sep 15, 2022
Merged

Moving Japanese content to translation/ja #452

merged 10 commits into from
Sep 15, 2022

Conversation

spier
Copy link
Member

@spier spier commented Sep 14, 2022

This PR contributes to a part of #430.

I moved all files from translation/japanese to translation/ja and adapted scripts and docs that contained the old folder name.

By changing this folder name things are more consistent with branch names (book-ja) the other book files (/book/ja) etc.

Deployed a staging version of this to:
https://innersourcecommons.gitbook.io/innersource-patterns-staging/v/ja-test/

As part of this I also improved the GHA workflow.
Now any folder starting with book-ja will generate the Japanese book, which should be helpful for testing purposes.

@spier
Copy link
Member Author

spier commented Sep 14, 2022

@yuhattor could you review this again? Now using ja in all the places.

When reviewing this, could you also double check the documentation, to make sure that we are explaining correctly how this all works? Thanks :)

Btw I would already go ahead and change the URL on Production to /v/ja, as that change does not require this branch here to be merged. I will confirm this with you in Slack to be sure.

@yuhattor
Copy link
Member

yuhattor commented Sep 14, 2022

Thank you! It's amazing:)
I think it is now clearer that it is in Japanese.

Copy link
Member

@yuhattor yuhattor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:)

@spier spier merged commit 529dc6a into main Sep 15, 2022
@spier spier deleted the book-ja-folder-move branch September 15, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants