Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs of book/translation/contribution #431

Merged
merged 5 commits into from
Aug 2, 2022
Merged

Conversation

spier
Copy link
Member

@spier spier commented Jul 28, 2022

Hi @yuhattor. The automatic PR assignment is working (as you can see in the Reviewers on the right-hand side).

I made some improvements to the explanation of
a) our book publishing process (removing info about the book-staging branch because we don't actually use that any more)
b) translation process - simplified some of the titles by removing "how to ..."
c) the contribution guidelines - pointing potential contributors to our translations to advertise that as one possible way to contribute

As you have recently gone through both the translation and contribution process, I would be very grateful if you could review this PR :)

@spier spier added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Jul 28, 2022
Copy link
Member

@yuhattor yuhattor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @spier for updating the README files:)

@yuhattor yuhattor merged commit 87f22b7 into main Aug 2, 2022
@yuhattor yuhattor deleted the improve-book-docs branch August 2, 2022 13:14
@yuhattor
Copy link
Member

yuhattor commented Aug 2, 2022

Sorry, a little late to respond!
I've merged!

@spier
Copy link
Member Author

spier commented Aug 2, 2022

Thanks for the review!

And no worries, it is completely ok if reviews take days, some even weeks, given that we are all donating time here to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants