Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed InnerSource casing and changed formatting #412

Merged
merged 4 commits into from
May 28, 2022
Merged

Fixed InnerSource casing and changed formatting #412

merged 4 commits into from
May 28, 2022

Conversation

MaineC
Copy link
Member

@MaineC MaineC commented May 13, 2022

On reading the pattern I noticed that InnerSource here is still written inconsistently.

@MaineC
Fixed InnerSource casing and changed formatting
69e8db7 
On reading the pattern I noticed that InnerSource here is still written inconsistently.
spier
spier reviewed May 13, 2022
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the IS spelling.

Left one comment where I don't understand the formatting.

Also there are some issues that the markdownlinter complains about that need fixing.

patterns/1-initial/overcoming-project-management-time-pressures.md Show resolved Hide resolved
spier
spier approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@spier spier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spier
Copy link
Member

spier commented May 28, 2022

While this pattern still has some other issues, the PR already represents an improvement to the spelling of InnerSource and some other formatting fixes.

Therefore let's merge this and leave further improvements to future PRs.

@spier spier added 1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR labels May 28, 2022
@spier spier merged commit b4d531c into main May 28, 2022
@spier spier deleted the casing branch May 28, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier approved these changes

@lenucksi lenucksi Awaiting requested review from lenucksi lenucksi is a code owner

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid NewMexicoKid is a code owner

@cewilliams cewilliams Awaiting requested review from cewilliams cewilliams is a code owner

@robtuley robtuley Awaiting requested review from robtuley robtuley is a code owner

Assignees
No one assigned
Labels
1-initial Donuts, Early pattern ideas, ... (Please see our contribution handbook for details) 📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaineC @spier