Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Process for Instating Trusted Committers #141

Merged
merged 9 commits into from
Apr 10, 2020
Merged

Update Process for Instating Trusted Committers #141

merged 9 commits into from
Apr 10, 2020

Conversation

maxcapraro
Copy link
Member

This pull request proposes ...

  • A lean process to instate trusted committers for the patterns working group
  • To instate @lenucksi as an additional trusted committer

In a call earlier today, @spier, @lenucksi, @MaineC, and I felt that this will be benficial for multiple reasons:

  • Having a dedicated mandate from the current trusted committers, would allow us to revive the working group and bring in our ideas, without the fear of trampling anyones feet
  • Having a (or a set of) trusted committers who currently want to and can commit time, will make sure that contributions (particularly those of new contributors) will be seen to quickly - motivating them to stay
  • Having an explicit process for instating new trusted committers, will make the instatement (and the responsibilities it brings) explicit
  • Having an explicit process enables us to motivate contributors; and reward their contributions

@maxcapraro maxcapraro added the ⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR label Mar 27, 2020
@maxcapraro
Copy link
Member Author

  1. @nyeates, @gruetter, @NewMexicoKid, @cewilliams you were listed explicitly as repo Admins. This is why I added you to the TC list. Please let me know if you have thoughts about this.
  2. What do we do with the many folks who have earned write access in the past? Do we simple want to add them to the TC list? Revoke write access? Let them their write acces but not add them to the list?

@maxcapraro maxcapraro mentioned this pull request Mar 27, 2020
Merged
@spier
Copy link
Member

spier commented Mar 27, 2020

Looks good to me.

I think you would also have to change the link to TRUSTED-COMMITTERS.md from within README.md?

@maxcapraro
Copy link
Member Author

maxcapraro commented Mar 27, 2020 •
edited
Loading

I think you would also have to change the link to TRUSTED-COMMITTERS.md from within README.md?

Thanks .... Indeed! I'll do that tomorrow :)

@maxcapraro
Copy link
Member Author

maxcapraro commented Mar 27, 2020 •
edited
Loading

Tomorrow became today. Fixed it (and created #142 to in hopes to avoid this in the future).

@MaineC
Copy link
Member

MaineC commented Mar 30, 2020

What do we do with the many folks who have earned write access in the past? Do we simple want
to add them to the TC list? Revoke write access? Let them their write acces but not add them to
the list?

I would ask them. That gives us an excuse to get in touch with them and talk about breathing more life into the patterns community - and it gives them the option to make a conscious decision.

If you need a template text to draft such an invitation:
http://community.apache.org/newcommitter.html#committer-invite-template (note to self: This needs to be turned into another InnerSource pattern.)

rrrutledge
rrrutledge requested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@rrrutledge rrrutledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your all work, here.

README.md Outdated Show resolved Hide resolved
TRUSTED-COMMITTERS.md Outdated Show resolved Hide resolved
@maxcapraro
Copy link
Member Author

I would ask them. [...]

Excellent! I agree :) Let's do that.

This does not need to stop this PR though, or does it?

rrrutledge
rrrutledge reviewed Apr 1, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
@lenucksi lenucksi requested a review from gruetter April 5, 2020 14:22
lenucksi
lenucksi reviewed Apr 5, 2020
View reviewed changes
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great PR to me.

TRUSTED-COMMITTERS.md

Trusted committers (TCs) are those members of our working group who have elevated rights and direct write access to this repository. *TCs act as stewards of the working group and community. They aim to make consensus-based decisions in the best interest of the working group.* They also act as the guardians of this repository: TCs react to, referee, and give feedback about incoming contributions.

## Current Trusted Committers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could also think about referring to a .github/codeowners file with the listed persons handles in it.
That would this would give a bit of automation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do it. :)
CODEOWNERS are awesome, and it is a cheap experiment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try that once this gets merged.

@maxcapraro maxcapraro merged commit 41d3e74 into InnerSourceCommons:master Apr 10, 2020
@maxcapraro
Copy link
Member Author

I merged this PR because:

spier
spier reviewed Apr 10, 2020
View reviewed changes
TRUSTED-COMMITTERS.md
## Admins
A handful of individuals are currently the technical GitHub Admins for this repository. This includes most members of the InnerSource Commons' #tech-infra team and members of the [InnerSource Commons GitHub Organization](https://github.com/innersourcecommons). However, please channel working group-specific requests through the trusted committers.

## References
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxcapraro do you want to keep this headline? That section doesn't have any content, so when looking at the rendered HTML it looks like there is something missing. I can send a PR to remove the section if you like.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. Thank you :) I deleted it.

@lenucksi lenucksi mentioned this pull request Apr 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spier spier spier left review comments

@lenucksi lenucksi lenucksi left review comments

@rrrutledge rrrutledge rrrutledge approved these changes

@NewMexicoKid NewMexicoKid Awaiting requested review from NewMexicoKid

@cewilliams cewilliams Awaiting requested review from cewilliams

@nyeates nyeates Awaiting requested review from nyeates

@gruetter gruetter Awaiting requested review from gruetter

Assignees
No one assigned
Labels
⚙️ Type - Meta Improving how we collaborate in this repo is the main focus of this issue / PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxcapraro @spier @MaineC @lenucksi @rrrutledge