Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeldrisdev #57

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Zeldrisdev #57

merged 4 commits into from
Jan 15, 2022

Conversation

Ryomen-Sukuna
Copy link
Member

No description provided.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 15, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 3.17%.

Quality metrics Before After Change
Complexity 11.68 🙂 13.75 🙂 2.07 👎
Method Length 116.62 🙂 125.00 😞 8.38 👎
Working memory 10.64 😞 10.98 😞 0.34 👎
Quality 49.32% 😞 46.15% 😞 -3.17% 👎
Other metrics Before After Change
Lines 522 553 31
Changed files Quality Before Quality After Quality Change
zeldris/modules/bans.py 44.15% 😞 40.54% 😞 -3.61% 👎
zeldris/modules/purge.py 69.05% 🙂 69.05% 🙂 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
zeldris/modules/bans.py ban 30 😞 349 ⛔ 14 😞 21.42% ⛔ Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/bans.py temp_ban 15 🙂 283 ⛔ 14 😞 33.14% 😞 Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/bans.py unban 13 🙂 213 ⛔ 12 😞 41.46% 😞 Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/bans.py kick 10 🙂 187 😞 10 😞 49.73% 😞 Try splitting into smaller methods. Extract out complex expressions
zeldris/modules/purge.py purge 6 ⭐ 179 😞 8 🙂 58.45% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Ryomen-Sukuna Ryomen-Sukuna merged commit bf1f193 into master Jan 15, 2022
@Ryomen-Sukuna Ryomen-Sukuna deleted the zeldrisdev branch January 15, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants