Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert inputs are the right type #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Assert inputs are the right type #21

wants to merge 2 commits into from

Conversation

FeSens
Copy link

@FeSens FeSens commented Jun 6, 2022

Assert the inputs are the correct type. There is no way for the end-user to know the right input type only by reading the documentation; therefore, code should speak by itself, asserting the correct type.

@pronics2004 pronics2004 self-requested a review June 6, 2022 14:27
@pronics2004
Copy link
Member

Thanks @FeSens. This is helpful and can be temporary fix.

Looks like we should support the use of dataloader in the fit method for BNNRegression similar to BNNClassification. I have created an issue to track that #22.

You are welcome to take this on if you wish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronics2004 pronics2004 Awaiting requested review from pronics2004

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FeSens @pronics2004