This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Fix deletion of image caused selection of the first image #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed the call to self.import_dir_images method that reloaded all of the images in directory.
Ledorub
commented
Apr 28, 2021
Comment on lines
+1431
to
+1432
| del self.m_img_list[self.cur_img_idx] | ||
| self.file_list_widget.takeItem(self.cur_img_idx) |
There was a problem hiding this comment.
Removing current image's path from the list of paths and from sidebar widget.
| del self.m_img_list[self.cur_img_idx] | ||
| self.file_list_widget.takeItem(self.cur_img_idx) | ||
|
|
||
| self.cur_img_idx -= 1 # self.open_next_img will increment idx. |
There was a problem hiding this comment.
Removal of a path caused left shift of all of the following paths and the next image's path has the same index as deleted one.
Decrementing because self.open_next_img will increment index later.
| if os.path.exists(delete_path): | ||
| os.remove(delete_path) | ||
| self.import_dir_images(self.last_open_dir) |
There was a problem hiding this comment.
No longer required. Removed not to reload all of the paths and widget items.
tzutalin
approved these changes
Apr 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
self.import_dir_imagessetsself.file_pathtoNonehttps://github.com/tzutalin/labelImg/blob/6b5c3c634b4ec2976d87414e4ae1de9cc1ed358c/labelImg.py#L1282
then rescans the directory
https://github.com/tzutalin/labelImg/blob/6b5c3c634b4ec2976d87414e4ae1de9cc1ed358c/labelImg.py#L1283-L1284
and reloads all items of the widget
https://github.com/tzutalin/labelImg/blob/6b5c3c634b4ec2976d87414e4ae1de9cc1ed358c/labelImg.py#L1287-L1289
afterwards calls
self.open_next_imagehttps://github.com/tzutalin/labelImg/blob/6b5c3c634b4ec2976d87414e4ae1de9cc1ed358c/labelImg.py#L1286
The following condition is met and
self.cur_img_idxis reset.https://github.com/tzutalin/labelImg/blob/6b5c3c634b4ec2976d87414e4ae1de9cc1ed358c/labelImg.py#L1351-L1353