-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getting started example #62
Conversation
<header className={headerStyles.wrapper}> | ||
<nav> | ||
<img src={src} alt={alt} width={width} height={height} /> | ||
<Menu fieldPath="menu" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent usage of MenuField!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to Routing, perhaps a README describing the various parts of the system at play here would be helpful. I think overall this is an excellent mix of features that exposes a healthy amount of complexity and capability.
I would no add more complications i.e. GraphQL, Serverless, etc..
@bmatto README has been added and is ready for feedback. |
examples/getting-started/README.md
Outdated
To set up your development environment to work with CMS React, you’ll need the following: | ||
|
||
- A HubSpot account with CMS Free, Starter, Pro, or Enterprise access | ||
- Node.js v16.0 or higher and the associated version of NPM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we specify Node 18 here
examples/getting-started/README.md
Outdated
npm run deploy | ||
``` | ||
|
||
This will upload the `getting-started-project` to your HubSpot account. Once uploaded, built, and deployed, you can add the modules and partials to your HubSpot templates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should say that the modules can be added pages as well, or even just used as any module would.
examples/getting-started/README.md
Outdated
|
||
You can preview your local CMS React components inside live HubL-rendered pages. To do this, create a page: | ||
|
||
- Go to Control Center |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Control Center" I think is an internal term - though probably littered in these docs... maybe refer to it as "Website Pages" in HubSpot.
Fixed 0aab365 |
This PR adds a new getting-started example that showcases a few key items when working with cms-react. The three modules in this PR are a Weather module that using client side data fetching and the free
WeatherAPI.com
API to get weather data for a given city. In addition to this module, we have a header and a footer module to show simpler modules. This example showcases the following:Open questions
Screenshots