Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated readme with new naming #60

Merged
merged 3 commits into from
May 21, 2024
Merged

Updated readme with new naming #60

merged 3 commits into from
May 21, 2024

Conversation

DanieleDiBenedetto
Copy link
Collaborator

No description provided.

JackPiri
JackPiri requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider updating also:

  • repository entry in Cargo.toml,
  • homepage entry in runtime/Cargo.toml,
  • homepage entry in node/Cargo.toml,

since those are non-code references.

Apart from these, the PR is fine.

JackPiri
JackPiri approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine to me thanks

@DanieleDiBenedetto DanieleDiBenedetto merged commit 69f8162 into main May 21, 2024
5 checks passed
@DanieleDiBenedetto DanieleDiBenedetto deleted the ddb/update_readme_m2 branch May 21, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giacgus giacgus giacgus approved these changes

@JackPiri JackPiri JackPiri approved these changes

@ptagl ptagl Awaiting requested review from ptagl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanieleDiBenedetto @giacgus @JackPiri