Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Hungarian layout #774

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

tenextractor
Copy link
Contributor

See the contributing section in the readme for more detailed guideline: https://github.com/Helium314/HeliBoard?tab=readme-ov-file#guidelines
tl;dr (you should still read the full list though):

  • make sure it's wanted
  • a single thing only
  • describe it properly
  • re-use existing mechanisms / code
  • low performance impact
  • make it a draft if you still want to work on it
  • don't do translation PRs

Further

  • When the PR contains "fixes" , the related issue will be linked and automatically closed if the PR is merged (also works for other words like "fix", "resolve", "resolves", "closes", ...)
  • If you add a keyboard layout, make sure you have read https://github.com/Helium314/HeliBoard/blob/main/layouts.md#adding-new-layouts--languages
  • Please avoid force-pushing when doing changes. This way it's not possible which parts have changed since the previous state.

fixes #758

@tenextractor
Copy link
Contributor Author

image

@Helium314
Copy link
Owner

This massively changes the layout for every user of the Hungarian default keyboard, which will create issues by users to switch back to the old layout.
Feel free to create an additional layout, but please don't do such large changes to the app defaults based on a single person's preference.

@tenextractor
Copy link
Contributor Author

Ok, I will add it as an additional layout.

@Helium314
Copy link
Owner

You could possibly make use of the recently added "language (extended)" string and set android:label="@string/subtype_generic_extended".
Do you need any help / information on how to add it as a new layout?

@tenextractor
Copy link
Contributor Author

tenextractor commented May 15, 2024

Thanks for the help. I was just busy on other things.

@Helium314 Helium314 merged commit f825436 into Helium314:main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Hungarian layout
2 participants