-
-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct EnumValueMap implementation #9670
base: development
Are you sure you want to change the base?
Correct EnumValueMap implementation #9670
Conversation
Something fails on C#:
|
# Conflicts: # std/haxe/ds/EnumValueMap.hx
I have updated the branch. It doesn't have 7dc9272, which I would like to solve in a cross-platform way because I have the same issue on the JVM target. I think we can add Edit: Actually that won't do because then we still have to create real arrays in order to check the individual elements. Not sure what a good API would look like here... |
... I never really looked at the actual implementation here though. Building a map on top of arrays can be done, but linear cost for both read and write isn't acceptable for maps. |
Fixes #2479
This is an implementation with correct
EnumValueMap
behavior for non-scalar enum parameters.Target-specific implementations could be added as a next step to improve runtime performance.