Skip to content

Commit

Permalink
test: refactor test-tls-inception
Browse files Browse the repository at this point in the history
* buffer-to-string comparison replaced with string-to-string comparison
* equal -> strictEqual
* var -> const
* rename identifiers to avoid masking

PR-URL: nodejs#9536
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
Trott committed Nov 12, 2016
1 parent f673c97 commit 9004bfe
Showing 1 changed file with 17 additions and 19 deletions.
36 changes: 17 additions & 19 deletions test/parallel/test-tls-inception.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,33 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');

var fs = require('fs');
var path = require('path');
var net = require('net');
const assert = require('assert');
const tls = require('tls');

var options, a, b;
const fs = require('fs');
const path = require('path');
const net = require('net');

var body = Buffer.alloc(400000, 'A');

options = {
const options = {
key: fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem')),
cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'))
};

const body = 'A'.repeat(40000);

// the "proxy" server
a = tls.createServer(options, function(socket) {
var options = {
const a = tls.createServer(options, function(socket) {
const myOptions = {
host: '127.0.0.1',
port: b.address().port,
rejectUnauthorized: false
};
var dest = net.connect(options);
const dest = net.connect(myOptions);
dest.pipe(socket);
socket.pipe(dest);

Expand All @@ -38,20 +37,19 @@ a = tls.createServer(options, function(socket) {
});

// the "target" server
b = tls.createServer(options, function(socket) {
const b = tls.createServer(options, function(socket) {
socket.end(body);
});

a.listen(0, function() {
b.listen(0, function() {
options = {
const myOptions = {
host: '127.0.0.1',
port: a.address().port,
rejectUnauthorized: false
};
var socket = tls.connect(options);
var ssl;
ssl = tls.connect({
const socket = tls.connect(myOptions);
const ssl = tls.connect({
socket: socket,
rejectUnauthorized: false
});
Expand All @@ -61,7 +59,7 @@ a.listen(0, function() {
buf += data;
});
ssl.on('end', common.mustCall(function() {
assert.equal(buf, body);
assert.strictEqual(buf, body);
ssl.end();
a.close();
b.close();
Expand Down

0 comments on commit 9004bfe

Please sign in to comment.