Skip to content

Commit

Permalink
build: do not indent assignments in Makefile
Browse files Browse the repository at this point in the history
Indented assignment in a Makefile can be interpreted
as a command in e.g. GNU Make 3.81 which results in the
following error:

```
make: CPPLINT_QUIET: No such file or directory
```

PR-URL: nodejs#29623
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
  • Loading branch information
joyeecheung authored and Trott committed Sep 22, 2019
1 parent aa32e13 commit 54a0553
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1312,9 +1312,9 @@ else
endif

ifeq ($(V),1)
CPPLINT_QUIET =
CPPLINT_QUIET =
else
CPPLINT_QUIET = --quiet
CPPLINT_QUIET = --quiet
endif
.PHONY: lint-cpp
# Lints the C++ code with cpplint.py and check-imports.py.
Expand Down

0 comments on commit 54a0553

Please sign in to comment.