feat : Add Article expiration reminder support #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @HEIGE-PCloud on Vercel. @HEIGE-PCloud first needs to authorize it. |
|
我想做的一些改动
|
这个我已经做过了。outdatedInfoWarning: false 可以添加在每篇文章的文件头里来控制是否启用该功能：
警告位置我已经修改过了。 |
- Rename outdatedInfoWarning to outdatedArticleReminder - Rename hint to reminder - Rename warn to warning - Move outdatedArticleReminder from params to params.pages - Add documentation for example config - Add documentation for front matter - Update translation for en and zh-CN - clean up code for outdatedArticleReminder.html
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pcloud/do-it/5aVhVXcH8bYEXY9VhAjqiBQBqKEV |
|
我做了一些 code clean up，加了一些文档。麻烦你再看一下，如果没有问题就可以合并了 👍 |
|
我已经测试过了没问题。 @HEIGE-PCloud |
CXwudi
reviewed
Oct 10, 2021
| @@ -629,6 +629,16 @@ enableEmoji = true | |||
| # Page style ("normal", "wide") | |||
| # 页面样式 ("normal", "wide") | |||
| pageStyle = "wide" | |||
| # Display a message at the beginning of an article to warn the reader that its content might be outdated. | |||
| # 在文章开头显示提示信息，提醒读者文章内容可能过时。 | |||
| [params.pages.outdatedArticleReminder] | |||
There was a problem hiding this comment.
想问一下, key值为params.pages而不是params.page有什么原因吗?
以及要是能改进一下indentation就好了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
效果如下所示：
