container: refactor node_config node pool update
#11826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modular-magician
added
the
awaiting-approval
This was referenced Sep 26, 2024
wyardley
force-pushed
the
wyardley/node_config_update/19225_partial
branch
from
5486b3d
to
8e3c116
Compare
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
wyardley
commented
Sep 26, 2024
| nodePoolInfo.project, | ||
| nodePoolInfo.location, | ||
| "updating GKE node pool disk_size_gb/disk_type/machine_type/storage_pools", userAgent, | ||
| timeout) |
There was a problem hiding this comment.
A lot of opportunity to DRY up these parts with a function at some point too, but trying to keep it pretty self-contained here for now.
This sets the stage for consolidating the logic for updating nodepools between the `container_cluster` and `container_node_pool` resources, by creating a new `nodePoolNodeConfigUpdate()` function. Part of hashicorp/terraform-provider-google#19225
wyardley
force-pushed
the
wyardley/node_config_update/19225_partial
branch
from
8e3c116
to
d467fd7
Compare
wyardley
changed the title
node_config node pool updatenode_config node pool update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the stage for consolidating the logic for updating nodepools between the
container_clusterandcontainer_node_poolresources, by creating a newnodePoolNodeConfigUpdate()function.Part of hashicorp/terraform-provider-google#19225
Release Note Template for Downstream PRs (will be copied)