-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data source "google_privileged_access_manger_entitlement" #11588
Conversation
varsharmavs
commented
Aug 30, 2024
•
edited
Loading
edited
…ty/components/inputs/services_beta.kt'
…pproval workflow set as ForceNew
…ment.yaml file to have min size 1 in principals field.
Co-authored-by: Nick Elliot <[email protected]>
…source_privileged_access_manager_entitlement_test.go.erb Co-authored-by: Nick Elliot <[email protected]>
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
reassigning due to OOO |
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Tests analyticsTotal tests: 4 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligns with the PAM Entitlement resource implemented previously and tests are good, LGTM! One comment for formatting that I'll commit in myself so this can be merged before go conversion.
mmv1/third_party/terraform/provider/provider_mmv1_resources.go.erb
Outdated
Show resolved
Hide resolved
…CloudPlatform#11588) Co-authored-by: Nick Elliot <[email protected]>