Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data source "google_privileged_access_manger_entitlement" #11588

Merged
merged 88 commits into from
Sep 23, 2024

Conversation

varsharmavs
Copy link
Contributor

@varsharmavs varsharmavs commented Aug 30, 2024

`google_privileged_access_manager_entitlement`

varsharmavs and others added 30 commits April 1, 2024 04:43
…ment.yaml file to have min size 1 in principals field.
…source_privileged_access_manager_entitlement_test.go.erb

Co-authored-by: Nick Elliot <[email protected]>
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic[Error message] [Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 19, 2024
Copy link

@melinath This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@melinath melinath requested review from a team and NickElliot and removed request for melinath and a team September 19, 2024 15:28
@melinath
Copy link
Member

reassigning due to OOO

@modular-magician modular-magician removed the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 20, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 172 insertions(+))
google-beta provider: Diff ( 3 files changed, 172 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic[Error message] [Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Sep 23, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 175 insertions(+))
google-beta provider: Diff ( 3 files changed, 175 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4
Passed tests: 2
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • privilegedaccessmanager

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic
  • TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_basic[Debug log]
TestAccDataSourceGooglePrivilegedAccessManagerEntitlement_optionalProject[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns with the PAM Entitlement resource implemented previously and tests are good, LGTM! One comment for formatting that I'll commit in myself so this can be merged before go conversion.

@modular-magician modular-magician added the awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests label Sep 23, 2024
@NickElliot NickElliot merged commit 151c1af into GoogleCloudPlatform:main Sep 23, 2024
4 of 5 checks passed
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/privilegedaccessmanager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants