Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR included handling of
e_data
withinKERB_ERROR
's for retrieval of the account salt from PA Data returned when a TGT was requested without preauth. This broke some errors (for instanceAP_ERR_MODIFIED
) wheree_data
isn't PA Data sections, as shown below:Fixed by putting a try/catch around decoding the
e_data
section and setting it to null if it fails: