New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use default vals for shutdownGracefully in shutdowns #760

Merged

Konicai merged 1 commit into GeyserMC:master from Konicai:shutdown-timing

Oct 1, 2023

Member

Konicai commented Oct 1, 2023

Default times were

quiet period -> 2 seconds
timeout -> 15 seconds

and its a shutdown hook so using sync() or await() doesn't seem necessary at all


          Don't use default vals for shutdownGracefully in shutdowns

8f50086

Camotoy approved these changes

View reviewed changes

Konicai merged commit d972296 into GeyserMC:master

1 check failed

Konicai deleted the shutdown-timing branch

October 1, 2023 20:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet