Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discard reserved fields from channel.Update() channelData #439

Merged
merged 7 commits into from
Sep 24, 2020
Merged

discard reserved fields from channel.Update() channelData #439

merged 7 commits into from
Sep 24, 2020

Conversation

gumuz
Copy link
Contributor

@gumuz gumuz commented Sep 23, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

@gumuz gumuz requested a review from nhannah September 23, 2020 12:39
@github-actions
Copy link
Contributor

github-actions bot commented Sep 23, 2020 •
edited
Loading

Size Change: +1.22 kB (0%)

Total Size: 193 kB

Filename Size Change
dist/browser.es.js 41.3 kB +275 B (0%)
dist/browser.full-bundle.min.js 27 kB +124 B (0%)
dist/browser.js 41.5 kB +272 B (0%)
dist/index.es.js 41.3 kB +273 B (0%)
dist/index.js 41.5 kB +271 B (0%)

compressed-size-action

@vishalnarkhede vishalnarkhede linked an issue Sep 23, 2020 that may be closed by this pull request
updating channel with new information removes previous data properties #436
Closed
vishalnarkhede
vishalnarkhede reviewed Sep 23, 2020
View reviewed changes
src/channel.ts Outdated Show resolved Hide resolved
gumuz and others added 2 commits September 23, 2020 15:06
gumuz
gumuz commented Sep 23, 2020
View reviewed changes
Copy link
Contributor Author

@gumuz gumuz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @nhannah

@gumuz gumuz merged commit ca4f5a5 into master Sep 24, 2020
@gumuz gumuz deleted the discard-reserved-fields branch September 24, 2020 07:35
@veloware
Copy link

any idea of when this will be released? Thanks

@gumuz
Copy link
Contributor Author

gumuz commented Oct 1, 2020

any idea of when this will be released? Thanks

hey @veloware these changes should now be included in v2.5.0

@veloware
Copy link

veloware commented Oct 1, 2020

just saw that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

@nhannah nhannah Awaiting requested review from nhannah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

updating channel with new information removes previous data properties
4 participants
@gumuz @veloware @vishalnarkhede @nhannah