-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: recent winners table #73
base: main
Are you sure you want to change the base?
fix: recent winners table #73
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Complexlity is attempting to deploy a commit to the G9 Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
I agree, but I think adding some form of pagination would be a better fix than reducing the scope of the sorting functionality to a total of 6 rows/entries. I think adding a "show more" button that when clicked, expands the card (to fit maybe to 10 entries?) and makes the card content scrollable (so you could scroll through to see all the winners) would be ideal. |
Makes sense. Did some updates. Here's how it looks now: final_recent_wins.mp4Only the English translation has been changed now (for the |
The current recent winners table takes in all the win data for a certain period (three months I believe).
If you try to sort by date or pay size, the whole table changes. This is because the sort doesn't use the actual recent wins shown to the user. It uses the entire data (many not shown).
Example Vault: przPool on Arbitrum
current:
current (sorted by date) :
fix (sorted by date) :
Since there's no pagination, it’s un-intuitive to show data that is not currently seen by the user