Skip to content
This repository has been archived by the owner on Oct 21, 2022. It is now read-only.

shuffle.js: remove newlines and carriage returns from gdPath before using it #20

Merged
merged 2 commits into from
Jun 15, 2022
Merged

shuffle.js: remove newlines and carriage returns from gdPath before using it #20

merged 2 commits into from
Jun 15, 2022

Conversation

layercak3
Copy link
Contributor

A lot of users that edit directory.txt may get the couldn't find your GD directory error because there's a newline (or maybe a carriage return) in it which a lot of editors add at the end of the file (the popular Windows Notepad is an exception when creating new files). There's a whole rabbit hole you can go down on about line endings but essentially this PR removes them because otherwise they're read as part of the pathname which will cause the game directory to not be found.

@GDColon
Copy link
Owner

GDColon commented Jun 15, 2022

Sounds good, just accepted a PR though so fix the conflict if possible

@GDColon GDColon merged commit 49fea56 into GDColon:master Jun 15, 2022
@NicoXploit
Copy link

NicoXploit commented Jun 15, 2022

Hello! For some reason my GD randomizer is not opening, not because it crashed or couldn't find the game folder, do you have to use a specific program?
Because the error message says:
"line 1
character: 1
synax error
Code: 800A03EA
Source: Microsoft JScript Compilation Error"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants