Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add captcha key config #37

Merged
merged 4 commits into from
Jun 23, 2023
Merged

feat: add captcha key config #37

merged 4 commits into from
Jun 23, 2023

Conversation

luizstacio
Copy link
Member

When using the faucet on projects locally, we should not display the captcha, and we should also remove the captcha key from the source code.

On this PR I create a new env config for CAPTCHA_KEY and add a optional render for the CAPTCHA based on the presence of the CAPTCHA_KEY.

@luizstacio luizstacio requested a review from xgreenx June 19, 2023 20:11
@luizstacio luizstacio self-assigned this Jun 19, 2023
@xgreenx
Copy link
Contributor

xgreenx commented Jun 19, 2023

What is the difference between CAPTCHA_SECRET and CAPTCHA_KEY?

@luizstacio
Copy link
Member Author

What is the difference between CAPTCHA_SECRET and CAPTCHA_KEY?

The CAPTCHA_SECRET is used by the API to verify if the captcha was correctly generated.
The CAPTCHA_KEY is a public key used to generate the captcha to be latter validated on the API.

xgreenx
xgreenx reviewed Jun 20, 2023
View reviewed changes
deployment/scripts/.env Outdated Show resolved Hide resolved
xgreenx
xgreenx approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!=) Did you check that it works as expected with proper fuel_faucet_captcha_key?

@xgreenx xgreenx merged commit 4f8dd7d into master Jun 23, 2023
7 checks passed
@xgreenx xgreenx deleted the feat/add-captcha_key-config branch June 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

Assignees

@luizstacio luizstacio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luizstacio @xgreenx