Skip to content

Commit

Permalink
chore: remove obsolete TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sangelovic committed Oct 31, 2023
1 parent b7b454b commit 9da18ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion include/sdbus-c++/Types.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ namespace sdbus {
Variant();

template <typename _ValueType>
/*explicit*/ Variant(const _ValueType& value) // TODO: Mark explicit in new major version so we don't break client code within v1
Variant(const _ValueType& value)
: Variant()
{
msg_.openVariant(signature_of<_ValueType>::str());
Expand Down
2 changes: 1 addition & 1 deletion src/Proxy.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ std::future<MethodReply> Proxy::callMethod(const MethodCall& message, uint64_t t
async_reply_handler asyncReplyCallback = [promise = std::move(promise)](MethodReply& reply, const Error* error) noexcept
{
if (error == nullptr)
promise->set_value(reply); // TODO: std::move? Can't move now because currently processed message. TODO: Refactor
promise->set_value(reply);
else
promise->set_exception(std::make_exception_ptr(*error));
};
Expand Down

0 comments on commit 9da18ae

Please sign in to comment.